-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-core): comments in the <pre> tag should be removed in production mode #2221
Conversation
Can we add a test that toggles production mode and checks this behavior? |
@posva yes I do it later |
Just ask, why not keep html comments in |
By default, comments are not kept in production, but you can achieve this by providing the |
The both ones below work with the same as each other in a pure html doc.
But the point is to fix the error of compiler. |
See f411924 - I refactored the logic to avoid duplicated code/iterations. |
Where exactly do I specify this |
Fix: #2217