Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Suspense single root node warning for dynamic component #2337

Closed
wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Oct 8, 2020

WIP: I'm looking for feedback on how to best solve this.

Currently, using:

<RouterView v-slot="{ Component }">
  <Suspense timeout="0">
    <component :is="Component" />
    <template #fallback>Loading...</template>
  </Suspense>
</RouterView>

throws the warning:

[Vue warn]: <Suspense> slots expect a single root node

This commit introduces some unit tests to reproduce the issue.

The code that needs to be updated is in componentRendererUtils.ts:

export function filterSingleRoot(children: VNodeArrayChildren): VNode | null {
  const filtered = children.filter(child => {
    return !(
      isVNode(child) &&
      child.type === Comment &&
      child.children !== 'v-if'
    )
  })
  return filtered.length === 1 && isVNode(filtered[0]) ? filtered[0] : null
}

A dynamic component is failing the test isVNode(filtered[0]) (IIUC what's going on).
What would be the proper way to fix this?

Currently, using:

```
<RouterView v-slot="{ Component }">
  <Suspense v-else timeout="0">
    <component :is="Component" />
    <template #fallback>Loading...</template>
  </Suspense>
</RouterView>
```

throws the warning:
```
[Vue warn]: <Suspense> slots expect a single root node
```

This commit introduces some unit tests to reproduce the issue.
@cexbrayat cexbrayat added the need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. label Feb 5, 2021
@posva
Copy link
Member

posva commented Jun 16, 2021

I think that #3962 should fix this but I could have forgotten some of the test cases

@cexbrayat
Copy link
Member Author

@posva nice job! I'll close this one since your PR should indeed fix it. Looking forward to get rid of this annoying warning with the next release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants