Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): should keep template nodes with no content (close #2463) #2468

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Oct 23, 2020

See #2463

This tweak is based on the following consideration:

An empty <template> block means it should render empty string, which is different from no <template> block.

@znck
Copy link
Member

znck commented Nov 3, 2020

SFC descriptor should keep all the blocks as some dev toolings depend on the structure of the file. e.g. VueDX/TS-Plugin auto imports components in <script> block but if descriptor.script is null it adds a <script> block.

@yyx990803 yyx990803 merged commit 5b9b37f into vuejs:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants