fix(compiler-dom): ensure global build filename matches the one defined in package.json (close #3181) #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in package.json
Size report
|
LinusBorg
added
🔨 p3-minor-bug
HcySunYang
approved these changes
Feb 7, 2021
LinusBorg
changed the title
yyx990803
added a commit
that referenced
this pull request
Feb 23, 2021
yyx990803
reviewed
Feb 23, 2021
| @@ -5,8 +5,8 @@ | |||
| "main": "index.js", | |||
| "module": "dist/compiler-dom.esm-bundler.js", | |||
| "types": "dist/compiler-dom.d.ts", | |||
| "unpkg": "dist/compiler-dom/global.js", | |||
| "jsdelivr": "dist/compiler-dom/global.js", | |||
| "unpkg": "dist/compiler-dom/compiler-dom.global.js", | |||
There was a problem hiding this comment.
It should be dist/compiler-dom.global.js
Fixed in fcb6c89
There was a problem hiding this comment.
Oh, thanks for spotting this.
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsoncurrently states:but the filename in /dist is
compiler-dom.global.jsthis PR adjusts the names in package.json
closes #3181