fix(runtime-core): cache the value returned from the default factory to avoid unnecessary watcher trigger #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid unnecessary watcher trigger
|
If we save the cache on the prop definition object, wouldn't it fail with two instances of the same component (as both would use the same reference to the same object)? It could also fail if people use the same prop object in two props (which they shouldn't), no? Maybe it's safer to save it in the instance? It could also use a Symbol to prevent exposing it |
|
@posva yes, I am aware of this and have corrected it. |
HcySunYang
changed the title
HcySunYang
added
❗ p4-important
posva
reviewed
Mar 24, 2021
| setCurrentInstance(instance) | ||
| value = defaultValue(props) | ||
| setCurrentInstance(null) | ||
| if (propsDefaultValue[key] !== undefined) { |
There was a problem hiding this comment.
We could also do
Suggested change
| if (propsDefaultValue[key] !== undefined) { | |
| if (key in propsDefaultValue) { |
It's shorter which probably doesn't matter here but it also avoids the else statement.
It's also 10% faster in Edge, Chrome and Firefox but 90% slower on Safari 😆 . So not sure if my suggestion is worth applying (https://jsbench.me/u7kmn8d67h/1)
edison1105
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3471
We should cache the return value from the default factory to avoid unnecessary watcher triggering, which is what Vue2 does.