fix(types): ImgHTMLAttributes loading property #3692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
changed the title
|
will this issue be solved by this PR? |
ftonato
suggested changes
Aug 27, 2021
| @@ -457,6 +457,7 @@ export interface ImgHTMLAttributes extends HTMLAttributes { | |||
| srcset?: string | |||
| usemap?: string | |||
| width?: number | string | |||
| loading?: "lazy" | "eager" | "auto"; | |||
There was a problem hiding this comment.
Hello,
Thank you for your contribution :)
Could you use single quote to be more consistent as other examples above?
There was a problem hiding this comment.
use prettier, lintstaged and husky to standardize the format other than manual control？
format is a engineer issue
There was a problem hiding this comment.
run npm run lint after perform your changes ;)
There was a problem hiding this comment.
Please format your code and resolve conflicts, also auto isn't a standard value.
MDN
edison1105
added
the
🍰 p2-nice-to-have
sxzz
reviewed
Apr 12, 2023
| @@ -457,6 +457,7 @@ export interface ImgHTMLAttributes extends HTMLAttributes { | |||
| srcset?: string | |||
| usemap?: string | |||
| width?: number | string | |||
| loading?: "lazy" | "eager" | "auto"; | |||
There was a problem hiding this comment.
Please format your code and resolve conflicts, also auto isn't a standard value.
MDN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3691