Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf( runtime-core): use apply to avoid spreading. #5985

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

zhangenming
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit d7ba011
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/628b09763402a900082ecf32

@zhangenming zhangenming reopened this May 23, 2022
@haoqunjiang haoqunjiang added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label May 29, 2024
@skirtles-code
Copy link
Contributor

I'm not sure what the original motivation was behind this change, but it seems reasonable to me.

A few notes:

  • I wondered whether the build tools might rewrite this code, but it seems to pass through relatively unchanged.
  • I did a search to see whether there were other instances of using call with ..., but these two seem to be the only uses.
  • Both of these changes are in the compat build only.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.9 kB 34.4 kB 31.1 kB
vue.global.prod.js 147 kB 54 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 20.9 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.1 kB 24.5 kB 22.3 kB

@edison1105 edison1105 added ready to merge The PR is ready to be merged. easy to merge labels Jul 30, 2024
@yyx990803 yyx990803 merged commit bb6babc into vuejs:main Aug 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. easy to merge ready to merge The PR is ready to be merged.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants