fix(reactivity-transform): don't overwrite scope and user imports #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
commented
Oct 9, 2022
Comment on lines
+156
to
+162
| // default symbol | ||
| if (!convertSymbol && !userImports[CONVERT_SYMBOL]) { | ||
| convertSymbol = CONVERT_SYMBOL | ||
| } | ||
| if (!escapeSymbol && !userImports[ESCAPE_SYMBOL]) { | ||
| escapeSymbol = ESCAPE_SYMBOL | ||
| } |
There was a problem hiding this comment.
Some opinions about the RFC: vuejs/rfcs#369 (comment)
antfu
approved these changes
Oct 10, 2022
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
… with macros (vuejs#6840) closes vuejs#6838
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
… with macros (vuejs#6840) closes vuejs#6838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6838
Fixed cases: