Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): should invoke transition hooks during hydration #6974

Closed
wants to merge 1 commit into from
Closed

fix(runtime-core): should invoke transition hooks during hydration #6974

wants to merge 1 commit into from

Conversation

zhangzhonghe
Copy link
Member

@zhangzhonghe zhangzhonghe commented Oct 27, 2022 •
edited
Loading

No description provided.

@zhangzhonghe zhangzhonghe force-pushed the fix-6951 branch 2 times, most recently from 5ebc4f6 to 68ba76b Compare October 27, 2022 15:38
@netlify
Copy link

netlify bot commented Oct 27, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit ce296bf
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/635b341f9e692d00086743a2

@zhangzhonghe zhangzhonghe force-pushed the fix-6951 branch 3 times, most recently from cf51c55 to ce296bf Compare October 28, 2022 01:45
@netlify
Copy link

netlify bot commented Oct 28, 2022

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit ce296bf
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/635b341f447020000823c816

@baiwusanyu-c
Copy link
Member

why closed this pr

@edison1105
Copy link
Member

why closed this pr

Maybe it is too late to perform animation in the hydration phase. This is what you'll see

  • element appearance -> page loaded
  • element disappearance -> hydration start
  • element reappearance

The correct way to do this is to perform the animation before the hydration. But vue doesn't have a similar thing like: https://www.solidjs.com/docs/latest/api#hydrationscript

@baiwusanyu-c
Copy link
Member

why closed this pr

Maybe it is too late to perform animation in the hydration phase. This is what you'll see

  • element appearance -> page loaded
  • element disappearance -> hydration start
  • element reappearance

The correct way to do this is to perform the animation before the hydration. But vue doesn't have a similar thing like: https://www.solidjs.com/docs/latest/api#hydrationscript

Thanks ！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangzhonghe @baiwusanyu-c @edison1105