fix(runtime-core): Support for custom transition classes when running in compat mode #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SxDx
changed the title
SxDx
changed the title
LinusBorg
reviewed
Jan 11, 2023
| @@ -194,7 +194,7 @@ export function resolveTransitionProps( | |||
| callHook(hook, [el, resolve]) | |||
| nextFrame(() => { | |||
| removeTransitionClass(el, isAppear ? appearFromClass : enterFromClass) | |||
| if (__COMPAT__ && legacyClassEnabled) { | |||
| if (__COMPAT__ && legacyClassEnabled && legacyAppearFromClass && legacyEnterFromClass) { | |||
There was a problem hiding this comment.
@SxDx I think a more straightforward solution could be to initialize these legacy*Class variables as empty strings on line 143-145
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #6253 custom transition classes (e.g. with tailwind) are currently not working when vue is running in compat/migration mode.
This PR just adds a few checks to the
Transitioncomponent to fix this.We have been running a vue version with this fix applied in production for months and found no problems.
close: #6253