-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move JSX DOM types back to @vue/runtime-dom
#7979
Merged
Merged
Commits on Mar 28, 2023
-
fix: copy-paste jsx-runtime types for global JSX namespace registration
Otherwise TypeScript will raise TS2322 errors. I have no idea why and how does the fix work. But it does. Even importing the `ReservedProps` and `NativeElements` types from `jsx-runtime` instead of declaring them in the module would fail the tests. I have no idea why, either. The failing tests are at https://github.com/vuejs/ecosystem-ci/actions/runs/4538928668/jobs/7998297656#step:7:3
Configuration menu - View commit details
-
Copy full SHA for e54dde1 - Browse repository at this point
Copy the full SHA e54dde1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d36547 - Browse repository at this point
Copy the full SHA 5d36547View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd45800 - Browse repository at this point
Copy the full SHA bd45800View commit details
Commits on Mar 29, 2023
-
fix: augment JSX types from
@vue/runtime-dom
should workFixes use cases such as https://github.com/vuetifyjs/vuetify/blob/29777628ac8839c0548e869d3d350ed9fdcbb149/packages/vuetify/src/shims.d.ts#L18-L25 Adds a new `./jsx.d.ts` entry in `@vue/runtime-dom` to avoid duplication in `vue`. It should be removed in 3.4 when we stop registering global JSX namespace by default.
Configuration menu - View commit details
-
Copy full SHA for 5088bd4 - Browse repository at this point
Copy the full SHA 5088bd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dc1894 - Browse repository at this point
Copy the full SHA 0dc1894View commit details -
fix(wip): move JSX DOM types back to
@vue/runtime-dom
Drops `vue/jsx-runtime/dom`. The previous commits didn't work because imported (and re-exported) types cannot be augmented. So I give up on the idea of moving the DOM types to `vue/jsx-runtime`. They don't pollute the global namespace anyway. There's still one caveat that I have to import the `IntrinsicElementAttributes` type from `@vue/runtime-dom/dist/runtime-dom` rather than using the package name as entry. Seems because in this monorepo, TypeScript always picks up the source file (`index.ts`) over the built file (`dist/runtime-dom.d.ts` as specified in the `types` field in `package.json`)
Configuration menu - View commit details
-
Copy full SHA for 241d222 - Browse repository at this point
Copy the full SHA 241d222View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5566fc0 - Browse repository at this point
Copy the full SHA 5566fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 429717f - Browse repository at this point
Copy the full SHA 429717fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 042e9d7 - Browse repository at this point
Copy the full SHA 042e9d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e04aae - Browse repository at this point
Copy the full SHA 1e04aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba9a2d5 - Browse repository at this point
Copy the full SHA ba9a2d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08fd197 - Browse repository at this point
Copy the full SHA 08fd197View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.