-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): fix missed updates when passing text vnode to <component :is> #8304
Merged
yyx990803
merged 9 commits into
vuejs:main
from
auvred:fix/fix-missing-updates-when-passing-text-vnode-to-component-is
Jun 5, 2024
Merged
fix(runtime-core): fix missed updates when passing text vnode to <component :is> #8304
yyx990803
merged 9 commits into
vuejs:main
from
auvred:fix/fix-missing-updates-when-passing-text-vnode-to-component-is
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvred
changed the title
fix(runtime-core): fix missed updates when passing text node to <components :is>
fix(runtime-core): fix missed updates when passing text vnode to <component :is>
May 13, 2023
edison1105
approved these changes
May 15, 2023
…ode-to-component-is
…ode-to-component-is
Would it be possible to add a test? |
@auvred is it possible to add a test please? |
Sorry for delay, I added test |
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
Size ReportBundles
Usages
|
edison1105
added
🐞 bug
Something isn't working
ready to merge
The PR is ready to be merged.
labels
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8298
The issue occurs when
cloned
initially hadpatchFlag === PatchFlags.TEXT
, soBut with
PatchFlags.TEXT = 1
And
patchFlag
becomes-1
and thenpatchFlag
is basicallyPatchFlags.HOISTED
, so it loses render patchescore/packages/shared/src/patchFlags.ts
Lines 104 to 107 in a374d7e