Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: enhance withDefaults type #8820

Closed
wants to merge 2 commits into from
Closed

types: enhance withDefaults type #8820

wants to merge 2 commits into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jul 20, 2023

closes #8601

  • Readonly
  • Respect undefined from default.
  • Remove ?: (optional) and add | undefined if no default.

@sxzz sxzz changed the title types: fix withDefaults type types: enhance withDefaults type Jul 20, 2023
@netlify
Copy link

netlify bot commented Aug 13, 2023

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit a06b5bd
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/64d8cfbef980190008beccf8

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 13, 2023
@sxzz sxzz removed the ready to merge The PR is ready to be merged. label Oct 20, 2023
@sxzz sxzz marked this pull request as draft October 20, 2023 07:43
@ferferga
Copy link
Contributor

@sxzz Given #8601 was merged, is this necessary?

@sxzz sxzz closed this May 30, 2024
@edison1105 edison1105 deleted the fix/default-type branch October 21, 2024 07:36
@edison1105 edison1105 restored the fix/default-type branch October 21, 2024 08:24
@edison1105 edison1105 reopened this Oct 21, 2024
@edison1105 edison1105 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VasylHulpak VasylHulpak VasylHulpak left review comments

Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sxzz @ferferga @VasylHulpak @edison1105