-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types(reactivity): fix the return type error when the toRaw parameter type is readonly #9124
Open
Alfred-Skyblue
wants to merge
10
commits into
vuejs:main
Choose a base branch
from
Alfred-Skyblue:fix-toRaw-readolny-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
types(reactivity): fix the return type error when the toRaw parameter type is readonly #9124
Alfred-Skyblue
wants to merge
10
commits into
vuejs:main
from
Alfred-Skyblue:fix-toRaw-readolny-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type is readonly
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #9124 will not alter performanceComparing Summary
|
The test cases can still pass without these changes |
@vue/compiler-dom
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-ssr
@vue/runtime-core
@vue/runtime-dom
@vue/reactivity
@vue/server-renderer
@vue/shared
@vue/compat
vue
commit: |
❌ Deploy Preview for vue-sfc-playground failed.
|
It seems that TypeScript currently allows this, see: microsoft/TypeScript#13347 However, microsoft/TypeScript#58296 is addressing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rawObj
is expected to be of typeFoo
, but the actual result is{ readonly a: number, readonly b: string, readonly c: {...} }
.