Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler-core): link errors to docs on prod #9165

Merged
merged 2 commits into from
Nov 27, 2023
Merged

refactor(compiler-core): link errors to docs on prod #9165

merged 2 commits into from
Nov 27, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Sep 7, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB (+39 B) 32.9 kB (+33 B) 29.7 kB (-14 B)
vue.global.prod.js 132 kB (+79 B) 49.7 kB (+58 B) 44.6 kB (+90 B)

Usages

Name Size Gzip Brotli
createApp 48 kB (+39 B) 18.9 kB (+31 B) 17.3 kB (+22 B)
createSSRApp 51.3 kB (+39 B) 20.2 kB (+34 B) 18.4 kB (+25 B)
defineCustomElement 50.4 kB (+39 B) 19.7 kB (+28 B) 18 kB (+25 B)
overall 61.4 kB (+39 B) 23.8 kB (+33 B) 21.6 kB (+35 B)

@sxzz sxzz force-pushed the refactor/error-msg-prod branch 2 times, most recently from fb551eb to a283667 Compare September 25, 2023 11:29
@sxzz sxzz mentioned this pull request Sep 25, 2023
Closed
@sxzz sxzz marked this pull request as ready for review September 25, 2023 11:29
@yyx990803
Copy link
Member

yyx990803 commented Sep 26, 2023 •
edited
Loading

Runtime errors should also be handled (runtime-core/src/errorHandling.ts)

@sxzz sxzz mentioned this pull request Sep 27, 2023
Merged
@yyx990803 yyx990803 changed the base branch from main to minor November 21, 2023 10:18
@yyx990803 yyx990803 merged commit aae3713 into minor Nov 27, 2023
15 checks passed
@yyx990803 yyx990803 deleted the refactor/error-msg-prod branch November 27, 2023 23:38
yyx990803 pushed a commit that referenced this pull request Nov 27, 2023
@sxzz @yyx990803
feat(dx): link errors to docs in prod build (#9165)
9f8ba98
@roberthand9 roberthand9 mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxzz @yyx990803