Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Vue 3 migration guide in docs #2090

Conversation

madogiwa0124
Copy link
Contributor

@madogiwa0124 madogiwa0124 commented Feb 20, 2023

Added a migration guide in further reading.

Vue 3 Migration Guide - v-on.native modifier removed
https://v3-migration.vuejs.org/breaking-changes/v-on-native-modifier-removed.html

Vue 3 Migration Guide - VNode Lifecycle Events
https://v3-migration.vuejs.org/breaking-changes/vnode-lifecycle-events.html#migration-strategy

Vue 3 Migration Guide - $listeners removed
https://v3-migration.vuejs.org/breaking-changes/listeners-removed.html

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the docs, thanks!
Do you know of other docs pages which could benefit from a link to the migration guide?

@madogiwa0124
Copy link
Contributor Author

madogiwa0124 commented Feb 20, 2023

@FloEdelmann

Thanks comment !

The following page may be equally benefit as there is no link to the migration guide.

There may be others, but if any of them look like they would benefit from an additional migration guide, I will add them 😃

@FloEdelmann
Copy link
Member

FloEdelmann commented Feb 20, 2023

Thanks for checking! Would you fancy adding those links to the relevant pages, too?

@madogiwa0124
Copy link
Contributor Author

@FloEdelmann

I Added migration guide! Could you please review again?

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!

docs/rules/no-deprecated-dollar-listeners-api.md Outdated Show resolved Hide resolved
docs/rules/no-deprecated-v-on-native-modifier.md Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann changed the title docs: Added a migration guide in further reading. Link to Vue 3 migration guide in docs Feb 20, 2023
@FloEdelmann FloEdelmann merged commit a4226ea into vuejs:master Feb 20, 2023
@madogiwa0124 madogiwa0124 deleted the add-further-reading-for-v-on-native-modifier branch February 20, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants