Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for imported types in SFC macros #2134

Merged
merged 12 commits into from
May 15, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Apr 18, 2023

This PR allows type-only defineProps and type-only defineEmits to be resolved from TypeScript type information as well. If the user is not using typescript-eslint, mark it as unknown.

@ota-meshi ota-meshi force-pushed the Support-imported-types-in-SFC-macros branch 2 times, most recently from 59137f9 to 81783b7 Compare May 11, 2023 11:10
@ota-meshi ota-meshi marked this pull request as ready for review May 11, 2023 11:16
@ota-meshi ota-meshi force-pushed the Support-imported-types-in-SFC-macros branch from 0d750cb to fc32e9f Compare May 12, 2023 08:13
@FloEdelmann FloEdelmann changed the title Add support imported types in SFC macros Add support for imported types in SFC macros May 12, 2023
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look a the utils themselves, but the tests and the rules look fine. Very nice improvement!

@ota-meshi ota-meshi merged commit 9abf469 into master May 15, 2023
@ota-meshi ota-meshi deleted the Support-imported-types-in-SFC-macros branch May 15, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants