Vuex and Pinia support for no-undef-properties
#2513
Merged
+608
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this rule should be supported by pinia or 3rd party plugin. |
Sure but it looks like the maintainers are welcoming these kinds of enhancements, as a similar fix was added for |
|
This is much required. Thanks to @marcjfj-vmlyr for working on this. Please merge as soon as possible. |
FloEdelmann
requested changes
Aug 29, 2024
… set, use isStringLiteral util
|
@FloEdelmann Thanks for reviewing! I've made the requested changes. |
FloEdelmann
requested changes
Sep 2, 2024
|
Invalid test cases have been added. |
FloEdelmann
requested changes
Sep 5, 2024
|
this looks great, can't wait for it to ship! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Vuex and Pinia methods to the
no-undef-propertiesrule, allowing properties defined bymapState,mapActions,mapGetters,mapMutations, andmapWritableStateto be recognized as defined properties.Test cases have been included for this enhancement.