fix(language-core): should wrap item with Reactive on v-for (#4902)

Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
vuejs · Oct 26, 2024 · 8c1672f · 8c1672f
1 parent e6e8ae5
commit 8c1672f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/packages/language-core/lib/codegen/globalTypes.ts b/packages/language-core/lib/codegen/globalTypes.ts
@@ -92,7 +92,11 @@ export function generateGlobalTypes(lib: string, target: number, strictTemplates
 	function __VLS_getVForSourceType(source: number): [number, number, number][];
 	function __VLS_getVForSourceType(source: string): [string, number, number][];
 	function __VLS_getVForSourceType<T extends any[]>(source: T): [
-		item: T[number],
+		item: ${(
+			target >= 3 ? `import('${lib}').Reactive<T[number]>` :
+				target >= 2.7 ? `import('${lib}').UnwrapNestedRefs<T[number]>` :
+					`T[number]`
+		)},
 		key: number,
 		index: number,
 	][];

diff --git a/packages/tsc/tests/__snapshots__/dts.spec.ts.snap b/packages/tsc/tests/__snapshots__/dts.spec.ts.snap
@@ -13,7 +13,7 @@ declare const _default: <Row extends BaseRow>(__VLS_props: NonNullable<Awaited<t
     attrs: any;
     slots: {
         default?(_: {
-            row: Row;
+            row: import("vue").Reactive<Row>;
         }): any;
     };
     emit: {};

diff --git a/test-workspace/tsc/passedFixtures/vue3/#3204/main.vue b/test-workspace/tsc/passedFixtures/vue3/#3204/main.vue
@@ -1,4 +1,4 @@
-<script setup lang="ts" generic="T">
+<script setup lang="ts" generic="T extends { foo: number }">
 import { exactType } from '../../shared';
 
 const props = withDefaults(defineProps<{
@@ -11,12 +11,12 @@ const props = withDefaults(defineProps<{
 
 <template>
 	<div v-for="item of list">
-		{{ exactType(item, {} as T) }}
+		{{ exactType(item.foo, {} as number) }}
 	</div>
 	<div v-for="item of props.list">
-		{{ exactType(item, {} as T) }}
+		{{ exactType(item.foo, {} as number) }}
 	</div>
 	<div v-for="item of $props.list">
-		{{ exactType(item, {} as T) }}
+		{{ exactType(item.foo, {} as number) }}
 	</div>
-</templat>
+</template>