Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate jsxTemplates #2677

Merged
merged 1 commit into from
Apr 22, 2023
Merged

refactor: deprecate jsxTemplates #2677

merged 1 commit into from
Apr 22, 2023

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Apr 22, 2023

In the past, we generated jsx format virtual code for templates based on the jsxTemplates option to obtain complete generic support, but with 1.4 substantially refactoring virtual code generation, we found a way to support generics for class components and functional components at the same time without relying on jsx , if you are interested in the principle, here is the playground link.

https://www.typescriptlang.org/play?#code/CYUwxgNghgTiAEYD2A7AzgF3gMQK4rAwEtUoIBhJAWwAdUQUMAueAHgBUA+AChpiRpoWAb3gA3MrhAt2AGnGSQQ+OwDaAXXgBfAJTwAvJ3hQUATwDcAKEuhIsBMnRZy0NGkq16jFihAB3Ni5efkERBQgpGXkJCKUZDW09Q3hRABI+AWUMUxoQJAAzeAzBbSsbcGg4eHz8QhIUYzQ8AmJSCmo6X0YOeQBpHmYVeQBrFl6dJksASHZ4EAAPDAZgNHhfAO4AOm3YAHNlE1Mko0P4AH5pqd65xeXVtOK0M5YiFHyQGHgABRC0LUupmd4MFMiwfpljsYzACfCAxB9pjIbksUCtgdtNnsDmZIacgexEWs4QjLAB6ABU5Ms8HJbGadTaHk6DCwMSk+gARJgYBz4Ew2UpOQBGXmkzjU8mk6yk0nwAACGDQAFoiLsUEg4JZHJhEB0hQZGvTWigyEyvBhuEb6qaOub5OscLVjTbPF0LaIBSwAOTcr3RRTKfW6HRlZC0IXcD2Kb2+-2xQOJeAy+C4NAIbK5MAAC3Aw3gcDQuAgWAwWaIqwgrxA0spErYLigbjNbvC7K5GB5fIFaGFovFNKlZNlCuVqvVmu1WDDNAATAbG1bGba3dwG03lyz7f54Gv3BvGJHW9J4D6O36jwng6GOjPD56T7GLywg3pk6n0zlwDmwHmC0WS2WFZVpYQA


Why is this important?

Note that this is not a breaking change, users should not be aware of this change, but just remove the jsxTemplates option from tsconfig as it is no longer needed.

Target version: >= v1.5.0 pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant