fix(tsc): remove fake global types holder #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
force-pushed
the
blake.newman/composite-projects
branch
from
4ceed5d
to
f2b373a
Compare
blake-newman
force-pushed
the
blake.newman/composite-projects
branch
4 times, most recently
from
e49060a
to
82bc942
Compare
42 tasks
blake-newman
force-pushed
the
blake.newman/composite-projects
branch
3 times, most recently
from
5dae83a
to
b685836
Compare
|
@blake-newman Made some adjustments, please let me know if this causes performance regression again in your project. |
remove fake global types holder, instead extracting global types when writing `.d.ts`. This allows composite projects to rebuild without detecting changes which adjusting `options.rootNames` was causing
blake-newman
force-pushed
the
blake.newman/composite-projects
branch
from
04d3e47
to
4da66a5
Compare
blake-newman
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composite projects currently do not rebuild efficently because we attach a fake place holder vue file. This is used to generate global types once for the project.
As the fake placeholder file is added the the roots file, the second build will detect a change because the root file does not exist for discovery with tsc.
remove adding the fake file to the roots, and instead apply the globals to the first vue file and then remove them when writing .d.ts.