Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-plugin-pug): should cache proxyed object #4626

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

KermanX
Copy link
Collaborator

@KermanX KermanX commented Jul 30, 2024

fix #4335.

This PR caches proxyed objects created by the Pug plugin, so that logic involving equality checking would work.

Previously, the following line doesn't remove v-for node because every time node.props generates a different array.

props: node.props.filter(prop => prop !== forDirective),

Prev image
Now image

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 5af4320 into vuejs:master Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

language-plugin-pug unused prop with v-slot and v-for
2 participants