Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-plugin-pug): compute offset correctly of pug class #4652

Merged
merged 9 commits into from
Aug 25, 2024

Conversation

KazariEX
Copy link
Collaborator

@KazariEX KazariEX commented Aug 6, 2024

fix #1767

@KazariEX
Copy link
Collaborator Author

KazariEX commented Aug 6, 2024

It should be noted that this currently only applies to cases where classnames are completely consecutive. Due to the code parsing logic, it cannot obtain the source offset for each class. I'm trying to find a solution.

@KazariEX KazariEX marked this pull request as ready for review August 6, 2024 05:20
Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: cb5d5a6

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4652

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4652

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4652

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4652

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4652

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4652

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4652

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4652

Open in Stackblitz

@johnsoncodehk
Copy link
Member

Thanks for looking into this!

@johnsoncodehk johnsoncodehk merged commit 812592c into vuejs:master Aug 25, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/issue-1767 branch August 26, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pug class literal underline range incorrect
2 participants