Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): should preserve generic info in directive #4686

Merged
merged 8 commits into from
Aug 25, 2024

Conversation

KermanX
Copy link
Collaborator

@KermanX KermanX commented Aug 13, 2024

fix #4682.

Previously, we inferred directives' argument types. However, this will cause the generic info to be lost. This PR avoids inferring the argument type.

Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: 67afc73

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4686

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4686

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4686

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4686

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4686

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4686

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4686

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4686

Open in Stackblitz

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 22eea60 into vuejs:master Aug 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-tsc failed to infer generic types of custom directives within templates
2 participants