feat: Add support for Quasar Framework #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octref
requested changes
Aug 9, 2018
| @@ -21,6 +25,20 @@ export const bootstrapTagProvider = getExternalTagProvider('bootstrap', bootstra | |||
| export const buefyTagProvider = getExternalTagProvider('buefy', buefyTags, buefyAttributes); | |||
| export const vuetifyTagProvider = getExternalTagProvider('vuetify', vuetifyTags, vuetifyAttributes); | |||
| @@ -68,6 +71,22 @@ export function getTagProviderSettings(workspacePath: string | null | undefined) | |||
| if (packageJson.dependencies['vuetify']) { | |||
| settings['vuetify'] = true; | |||
| } | |||
|
|
|||
| const quasarPath = ts.findConfigFile( | |||
There was a problem hiding this comment.
Follow the pattern above
- Check if dependencies have
quasar-framework - If so, call into the function
getQuasarTagProvider, which should encapsulate the code for findingpackage.json, etc - If that returns null, do nothing
- If that returns the
tagProvider, set settings to true and push it toallTagProviders.
There was a problem hiding this comment.
This is best for all the ways Quasar can be consumed (through Quasar CLI, vue-cli-plugin-quasar, etc etc). Explained on private.
|
Need to fix Travis which uses node 6, as Quasar depends on Node 8. This is fine for Vetur since in next release of VS Code we jump to Node 8.9.3 with Electron 2. |
|
What is it beneficial for this? |
|
@TonyPythoneer When you install
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.