Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): local search showDetailedList not working in pro env in windows #2253

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

zonemeen
Copy link
Collaborator

fix #2245

The function slash should be inside the function pathToFile.

@brc-dd
Copy link
Member

brc-dd commented Apr 18, 2023

Yeah, but it still won't fix that issue.

@brc-dd brc-dd merged commit 09be057 into vuejs:main Apr 18, 2023
@zonemeen
Copy link
Collaborator Author

My Windows device does not report errors after this fix. Can you tell me where is the other bugs? Thanks

@zonemeen zonemeen deleted the fix/localSearch branch April 18, 2023 09:43
@brc-dd
Copy link
Member

brc-dd commented Apr 18, 2023

Hi, read that issue you linked. (Comments near the bottom. Not its body.) They are getting separate errors like data not properly injected. Those are because of how we are rendering excerpts. (And it's happening for me on Mac too, so it's not specific to Windows. It's only happens when you've useData calls in pages.)

@zonemeen
Copy link
Collaborator Author

I'll try to fix this when I have time later.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detailed view in local search breaks if fetched excerpt has useData call
2 participants