feat(theme): use inert to avoid traverse menus and content with keyboard #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
commented
May 1, 2023
| @@ -36,27 +39,27 @@ provide('hero-image-slot-exists', heroImageSlotExists) | |||
| <template> | |||
| <div v-if="frontmatter.layout !== false" class="Layout"> | |||
| <slot name="layout-top" /> | |||
There was a problem hiding this comment.
should we wrap layout-top and layout-bottom slots for inert?
There was a problem hiding this comment.
should we also provide some inert-* in the Layout?
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
7ad4a4e to
f0d3082
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
inertattribute to prevent traverse content and menu on narrow sreens:isScreenOpenoutside the composableLayoutto deal withinertattribute, right now the attribute is not being handled byvue, if present handled as present (vue is rendering the attribute asinert="false")This PR fixes #1332 (closed by #1491, but not working in current version, check video)
https://streamable.com/tf9qtu
inertattribute supported by all major browsers: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/inert#browser_compatibilityTODO: removeundefinedwhen vuejs/core#8209 merged