Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable autocomplete in LocalSearchBox #4066

Merged
merged 3 commits into from
Oct 12, 2024
Merged

fix: disable autocomplete in LocalSearchBox #4066

merged 3 commits into from
Oct 12, 2024

Conversation

geecu
Copy link
Contributor

@geecu geecu commented Jul 19, 2024

Description

The autocomplete suggestions would appear on top of the search results, occulting a part of them, requiring the user to press "Esc" to hide the autocomplete results in order to see the search results fully.

Linked Issues

There's no issue open about this yet.

Additional Context

No.


Tip

The author of this PR can publish a preview release by commenting /publish below.

The autocomplete suggestions would appear on top of the search results,
occulting a part of them, requiring the user to press "Esc" to hide
the autocomplete results in order to see the search results fully.
@github-actions github-actions bot added the stale label Sep 1, 2024
@giladgd
Copy link

giladgd commented Sep 13, 2024

@brc-dd I see this PR was automatically marked as stale, but I think it's highly needed.
Is there something blocking the merge of this PR that I can help with?

@geecu
Copy link
Contributor Author

geecu commented Sep 13, 2024

/publish

Copy link

pkg-pr-new bot commented Sep 13, 2024

pnpm add https://pkg.pr.new/vitepress@4066

commit: 109e0c1

@brc-dd brc-dd merged commit 92b92ae into vuejs:main Oct 12, 2024
8 of 9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants