fix(theme): remove some explicit fonts #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/publish |
commit: |
|
Need someone to confirm this on Chrome on Windows 10 or 11 (who hasn't customized fonts in Chrome/Win settings) - what does this show:
|
|
online version: local version:
|
brc-dd
added a commit
that referenced
this pull request
Oct 18, 2024
these are already handled by `sans-serif` PingFang SC is used on macOS Noto Sans CJK is used on Ubuntu Microsoft YaHei is used on Windows follow up on #4286
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These fonts before
sans-serifhave poor rendering on Windows, remove them so that users who don't havePingFang SC&Noto Sans SC'installed can still set their preferred fonts.Tip
The author of this PR can publish a preview release by commenting
/publishbelow.