-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass Packages is Not Supported #137
Comments
The answer is to be found directly on the installation page that you linked to:
TBH in my personal experience I haven'T come across a project using
Why? Are there technical problems or conflicts?
Already possible: {
"jest": {
"globals": {
"vue-jest": {
"experimentalCSSCompile": true
}
}
}
} Relevant documentation: |
Well hot damn! Turning off CSS compilation did the trick, thank you! Yeah, I realize node-sass is faster, I'm just trying to figure out why it would be required when sass should work just as well. The sass package is dart-sass compiled to JavaScript so it technically is the "reference implementation of Sass". It seems like using the reference implementation should at least be an option when using this package. Parcel has support for node-sass but there's a bug that's mentioned in the docs so they default to sass. Installing node-sass basically kicks Parcel over to use that instead of sass and there are oddities there that I'm trying to avoid by using sass. Anyway, my issue was solved by disabling |
FYI -> vuetify 2 (currently in beta) requires specifically sass and not node-sass, so if someone want to use vuetify and sass in their project they are forced to also install node-sass just for vue-jest. |
Hi! You have @vue/component-compiler-utils@^2.4.0 dependency that in 3.x version has dropped node-sass in favor of sass. Have you any plans to update your @vue/component-compiler-utils? I think it will be better if @vue/component-compiler-utils delegate choice of preprocessor implementation to user as it is done in sass-loader (https://github.com/webpack-contrib/sass-loader/blob/master/src/getDefaultSassImplementation.js) and move node-sass and sass to peerDependencies.
|
@dkonchekov thanks for pointing this out. Are you using version 3.x of vue-jest? That's what comes out of the box with the Vue CLI jest plugin |
#209 should solve this. We need to get the Vue CLI Jest plugin onto the latest major version of vue-jest, but if you install the beta for vue-jest you should see this working. |
Maybe there's a good reason for it, but it strikes me as odd that "node-sass" is required when sass is listed on the installation page. I'm currently using sass with Parcel and installing both sass and node-sass isn't an option, so the requiring node-sass is making testing basically impossible for me. Would it be possible to use one or the other, or provide an option to skip style compilation altogether?
Thank you!
The text was updated successfully, but these errors were encountered: