Fix: support for class component mixins #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for using class component with mixins and also for importing Vue from vue-property-decorator instead of vue-class-component.
|
@lmiller1990 Any chance you can take a look at this? |
lmiller1990
approved these changes
May 5, 2021
|
Thanks! Credits to you though, without your video on debugging this earlier I wouldn't have gotten there ;) |
|
I should make some more videos explaining how this code base (and Test Utils) work - at the moment neither of them is very approachable (especially this code base - this is one of the most complex Jest transformers out there). I'll wait until the end of the week and do a release... hopefully we can get this issue fixed and merged, too, and it can go out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for using class component with mixins and also for importing
Vue from vue-property-decorator instead of vue-class-component.
See for more details: vuejs/test-utils#544