fix: pick up production env in thread-loader context

fix vuejs/core#3921
vuejs · Jul 16, 2021 · 821a3a3 · 821a3a3
1 parent 5f41112
commit 821a3a3
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -89,7 +89,8 @@ export default function loader(
     {}) as VueLoaderOptions
 
   const isServer = options.isServerBuild ?? target === 'node'
-  const isProduction = mode === 'production'
+  const isProduction =
+    mode === 'production' || process.env.NODE_ENV === 'production'
 
   const filename = resourcePath.replace(/\?.*$/, '')
   const { descriptor, errors } = parse(source, {

diff --git a/src/resolveScript.ts b/src/resolveScript.ts
@@ -32,7 +32,8 @@ export function resolveScript(
     return null
   }
 
-  const isProd = loaderContext.mode === 'production'
+  const isProd =
+    loaderContext.mode === 'production' || process.env.NODE_ENV === 'production'
   const isServer = options.isServerBuild ?? loaderContext.target === 'node'
   const enableInline = canInlineTemplate(descriptor, isProd)
 

diff --git a/src/stylePostLoader.ts b/src/stylePostLoader.ts
@@ -14,7 +14,7 @@ const StylePostLoader: webpack.loader.Loader = function (source, inMap) {
     map: inMap,
     scoped: !!query.scoped,
     trim: true,
-    isProd: this.mode === 'production',
+    isProd: this.mode === 'production' || process.env.NODE_ENV === 'production',
   })
 
   if (errors.length) {

diff --git a/src/templateLoader.ts b/src/templateLoader.ts
@@ -21,7 +21,8 @@ const TemplateLoader: webpack.loader.Loader = function (source, inMap) {
     {}) as VueLoaderOptions
 
   const isServer = options.isServerBuild ?? loaderContext.target === 'node'
-  const isProd = loaderContext.mode === 'production'
+  const isProd =
+    loaderContext.mode === 'production' || process.env.NODE_ENV === 'production'
   const query = qs.parse(loaderContext.resourceQuery.slice(1))
   const scopeId = query.id as string
   const descriptor = getDescriptor(loaderContext.resourcePath)