Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isObjectEqual will throw exception when object contains null value #1566

Closed
CzBiX opened this issue Jul 5, 2017 · 2 comments
Closed

isObjectEqual will throw exception when object contains null value #1566

CzBiX opened this issue Jul 5, 2017 · 2 comments
Labels
regression

Comments

@CzBiX
Copy link

CzBiX commented Jul 5, 2017 •
edited
Loading

Version

2.7.0

Reproduction link

https://jsfiddle.net/t8gpt9mk/

Steps to reproduce

Click router link in page.

What is expected?

Query in url changed.

What is actually happening?

Throw TypeError.

This code works well on vue-router 2.5.3, and bug introduce by pull request #1425.
callumacrae added a commit to callumacrae/vue-router that referenced this issue Jul 5, 2017
@callumacrae
Fix bug where isObjectEqual throws exception with null values.
f0b5349 
Fixes vuejs#1566.
@callumacrae callumacrae mentioned this issue Jul 5, 2017
Closed
posva added a commit that referenced this issue Jul 5, 2017
@posva
Handle null values when comparing objects
e53647a 
Fix #1566
@posva posva mentioned this issue Jul 5, 2017
Merged
@posva
Copy link
Member

posva commented Jul 5, 2017

Thanks for a more comprehensive bug report! 😄

@CzBiX CzBiX mentioned this issue Jul 5, 2017
Closed
@tebaly
Copy link

tebaly commented Sep 13, 2017

May be omit query parameter if is Null, like axios?

yyx990803 pushed a commit that referenced this issue Oct 11, 2017
@posva @yyx990803
fix: handle null values when comparing objects (#1568)
4e95bd8 
Fix #1566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@posva @CzBiX @tebaly