-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue-router 3.0.5 incorrectly encodes route on async load (but works fine on 3.0.4) #2719
Closed
719media opened this issue
Apr 16, 2019
· 1 comment
· Fixed by mariazevedo88/hash-generator-js#5, tghelere/valorize-vidas#4, tghelere/DeliVuery#18, tghelere/dailymages#2 or tghelere/vuestore#4
Closed
vue-router 3.0.5 incorrectly encodes route on async load (but works fine on 3.0.4) #2719
719media opened this issue
Apr 16, 2019
· 1 comment
· Fixed by mariazevedo88/hash-generator-js#5, tghelere/valorize-vidas#4, tghelere/DeliVuery#18, tghelere/dailymages#2 or tghelere/vuestore#4
Labels
Comments
I'm reverting back that change and adding some extra tests |
This was referenced Aug 29, 2019
This was referenced Oct 26, 2019
This was referenced Jan 20, 2020
This was referenced Feb 5, 2020
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.4
michaelwybraniec/vue-vuex-jwt-authentication-example#2
Open
This was referenced Mar 24, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
3.0.5
Reproduction link
https://codesandbox.io/s/1znn98wx47
Steps to reproduce
https://codesandbox.io/s/1znn98wx47
Follow instructions by navigating to ComponentB by clicking on the link. If you don't immediately see the problem, then click the refresh icon to simulate reloading assets/page (because the componentB must async load and not already be stored in cache).
Notice that the route path is now URL encoded.
What is expected?
Route path should not be URL encoded. In most browsers, the URL address bar up top will actually also change the URL as well to this encoded version, which obviously is unsightly for people who care about a clean URL
What is actually happening?
Route path is URL encoded. This has the unfortunate side effect of changing the URL bar in chrome. If you visit domain.com/a/b/c it will change to domain.com/a%2Fb%2Fc which is undesirable.
This works fine in 3.0.4. The regression is due to this line change
vue-router/src/util/resolve-components.js
Line 33 in 6974a6f
The text was updated successfully, but these errors were encountered: