Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationDuplicated Error after addRoute #3216

Closed
cropr opened this issue Jun 2, 2020 · 1 comment · Fixed by #3228
Closed

NavigationDuplicated Error after addRoute #3216

cropr opened this issue Jun 2, 2020 · 1 comment · Fixed by #3228

Comments

@cropr
Copy link

cropr commented Jun 2, 2020

Version

3.3.2

Reproduction link

https://jsfiddle.net/cropr/86vnLj4k/

Steps to reproduce

Following scenario fails with NavigationDuplicated

  1. Have a router wildcard and navigating to an non existing url e.g. /aroute
  2. Doing a addRoute in the handling component of the wildcard, resulting in an updated routing table with a matching /aroute
  3. Trying to navigate to new /aroute either via $router.push or $router.replace

While the url does not change, the Navigation changes and thus the NavigationDuplicated error is incorrect

What is expected?

The router is changed to the new component matching /aroute

What is actually happening?

NavigationDuplicated error raised

@posva
Copy link
Member

posva commented Jun 2, 2020

please complete the reproduction

posva added a commit that referenced this issue Jun 12, 2020
posva added a commit that referenced this issue Jun 12, 2020
Checking for the length is not enough when having a path: '*' route
Closes #3216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants