Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing renaming #3204

Merged
merged 1 commit into from
May 19, 2020
Merged

fix: Missing renaming #3204

merged 1 commit into from
May 19, 2020

Conversation

lmichelin
Copy link
Contributor

@lmichelin lmichelin commented May 19, 2020 •
edited
Loading

This PR fixes a missing renaming in #3047

See this comment for more details: #3047 (review)

@lmichelin lmichelin mentioned this pull request May 19, 2020
Merged
posva
posva approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! This is the kind of things that are caught with TypeScript 😓

@posva posva merged commit 1bc23f1 into vuejs:dev May 19, 2020
@schmidtk
Copy link

Thanks for the quick PR! This is the kind of things that are caught with TypeScript 😓

Or the Closure Compiler, if you're into that sort of thing. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmichelin @schmidtk @posva