WIP: Migrate to jest #1587
Closed
WIP: Migrate to jest #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, good job. |
|
Still WIP. For the browser, we used Karma. We can consider the "newer" combo of Jest + puppeteer. We should also look to use that in VTU v2 (currently no browser tests). |
|
Update... all files in Next is figure out how to run these in a browser (previously karma, still an option) and consider running the tests using the src instead of the built files (but have both in the CI run). |
13 tasks
|
closed in favor of #1629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got Jest mostly working, just going through and updating the tests.
resolves #1585
Edit 9 July: I am still working on this, might be a little bit longer. Rollup migration may have to wait, for now I will just focus on getting us on Jest.