feat(vapor-runtime): object support in v-for
#139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
sxzz
reviewed
Feb 27, 2024
packages/runtime-vapor/src/for.ts
Outdated
| for (let i = 0; i < commonLength; i++) { | ||
| update((newBlocks[i] = oldBlocks[i]), source[i]) | ||
| if (isObject(source) && !isArray(source)) { | ||
| const keys = Object.keys(source) |
packages/runtime-vapor/src/for.ts
Outdated
| @@ -55,9 +56,18 @@ export const createFor = ( | |||
| } | |||
|
|
|||
| const mountList = (source: any[], offset = 0) => { | |||
sxzz
force-pushed
the
yev-wang/vapor-runtime/v-for
branch
from
196d3e8
to
ee6934f
Compare
sxzz
force-pushed
the
yev-wang/vapor-runtime/v-for
branch
from
ee6934f
to
18ee972
Compare
sxzz
added a commit
that referenced
this pull request
Feb 29, 2024
Co-authored-by: wangjie36 <826036140@qq.com> closes #139
sxzz
added a commit
that referenced
this pull request
Feb 29, 2024
closes #139 Co-authored-by: wangjie36 <826036140@qq.com>
|
Thanks for your contribution. Implemented via 4af8e87 which combined with your commit. |
|
I assume the readme should also be updated? |
|
Thanks for your reminder. Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for object iteration in v-for