Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue.extend causes nested mixins to be merged twice #8865

Closed
KaelWD opened this issue Sep 29, 2018 · 3 comments · Fixed by #8870
Closed

Vue.extend causes nested mixins to be merged twice #8865

KaelWD opened this issue Sep 29, 2018 · 3 comments · Fixed by #8870

Comments

@KaelWD
Copy link
Contributor

KaelWD commented Sep 29, 2018

Version

2.5.17

Reproduction link

https://codepen.io/anon/pen/ReNVra?editors=0011

Steps to reproduce

Open the console

What is expected?

"mixinA created"
"mixinB created"
"ChildComponent created"

What is actually happening?

"mixinA created"
"mixinA created"
"mixinB created"
"ChildComponent created"

MixinB.options still has mixins, which gets applied again if used in mixins: [] or extends: even though Vue.extend() has already done that
@posva
Copy link
Member

posva commented Sep 29, 2018 •
edited
Loading

Don't use Vue.extend on a mixin, a mixins are plain objects

@posva posva closed this as completed Sep 29, 2018
@KaelWD
Copy link
Contributor Author

KaelWD commented Sep 29, 2018

Not if you use typescript they aren't.

@johnleider
Copy link
Contributor

Can you provide an example of how to handle this when using typescript @posva ?

KaelWD added a commit to KaelWD/vue that referenced this issue Sep 30, 2018
@KaelWD
fix(mergeOptions): skip mixins and extends if child is already merged
a59112f 
fixes vuejs#8865
@KaelWD KaelWD mentioned this issue Sep 30, 2018
Merged
13 tasks
yyx990803 pushed a commit that referenced this issue Nov 30, 2018
@KaelWD @yyx990803
fix(core): skip mixins and extends if child is already merged (#8870)
80f17fa 
fix #8865
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
@KaelWD
fix(core): skip mixins and extends if child is already merged (vuejs#…
0c06e2d 
…8870)

fix vuejs#8865
aJean pushed a commit to aJean/vue that referenced this issue Aug 19, 2020
@KaelWD @aJean
fix(core): skip mixins and extends if child is already merged (vuejs#…
b8bd788 
…8870)

fix vuejs#8865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #8865: skip mixins and extends if child is already merged KaelWD/vue
3 participants
@posva @johnleider @KaelWD