-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-throwing error within Vue.config.errorHanlder results in error thrown twice #9445
Re-throwing error within Vue.config.errorHanlder results in error thrown twice #9445
Comments
This is expected: it's possible that your code in the globalHandler itself has errors, and that error is thus reported as a potential error in your error handling code. If you already have an error handler, you should not be throwing the error. |
Yes, errors in the global handler should be thrown, but only once and not twice. Or am I missing something?
If I don't throw the error then the error get's completely swallowed: https://jsfiddle.net/d6uqhk0r/ (Thanks for Vue, it's super impressive how much you achieved.) |
This is now fixed - note that to avoid the error being logged twice, you need to throw the original error instead of |
Awesome thanks |
Version
2.5.22
Reproduction link
https://jsfiddle.net/h92m7pad/2/
Steps to reproduce
What is expected?
The error is thrown once
What is actually happening?
It is thrown twice
The text was updated successfully, but these errors were encountered: