Fastcoding Inc broken icon #10638
Merged
Fastcoding Inc broken icon #10638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've recently send a PR to vuejs.org with a .png version of the Fastcoding Inc logo. When/if it's merged, change this .svg link to .png.
|
UPDATE: The PR is now merged to master for vuejs.org and fastcoding_inc.png is available via the updated link. |
|
ping @yyx990803 |
PhilipJohnBasile
approved these changes
Oct 15, 2019
|
Hey @Naartti, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Lostlover
pushed a commit
to Lostlover/vue
that referenced
this pull request
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently send a PR to vuejs.org with a .png version of the Fastcoding Inc logo. When/if it's merged, change this .svg link to .png.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
It's just one logo-link in the README that's a svg, all other are png.