feat(ssr): vue-ssr-webpack-plugin compatible with webpack 5 #12002
Conversation
posva
changed the title
|
Hi colleagues. The last activity was several weeks ago... Currently, we try to move to Webpack 5 and have troubles with Vue SSR plugin. Please give some roadmap to adjust our deadlines and make appropriate decisions. Thanks in advance. |
|
@redneckz It's not a good practice, but you can copy https://github.com/gzzhanghao/vue/tree/ssr-webpack-5-build/packages/vue-server-renderer |
| @@ -31,5 +31,8 @@ | |||
| "devDependencies": { | |||
| "vue": "file:../.." | |||
| }, | |||
| "peerDependencies": { | |||
| "webpack": "*" | |||
There was a problem hiding this comment.
It is an optional peer dependency.
Users should be able to use this package without webpack.
| @@ -10,7 +10,8 @@ export default class VueSSRServerPlugin { | |||
| apply (compiler) { | |||
| validate(compiler) | |||
|
|
|||
| onEmit(compiler, 'vue-server-plugin', (compilation, cb) => { | |||
| const stage = 'PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER' | |||
There was a problem hiding this comment.
Why not just put the stage name in the onEmit function? It's not used anywhere else
There was a problem hiding this comment.
@sodatea client plugin and server plugin are applied in different stage, so I think it's better to specify the stage name here.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Similar to #11863, but:
Fix #11718
Close #11863