-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(git): ignore dist files until release #5984
Conversation
35a7241
to
01f823f
Compare
packages/vue-server-renderer/build.js | ||
packages/vue-server-renderer/server-plugin.js | ||
packages/vue-server-renderer/client-plugin.js | ||
packages/vue-template-compiler/build.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove \n
from the end? cat
users will hate you 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
ignore dist files until release improves contributor experience ensures dist files can't be accidentally committed in
01f823f
to
3e48d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even a contributor, but anyway, LGTM, I'd like this to be merged.
@yyx990803 Ill put this across all the core repos with dist folders in coming days. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Reasons
ignore dist files until release
improves contributor experience
ensures dist files can't be accidentally committed in