Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(git): ignore dist files until release #5984

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

blake-newman
Copy link
Member

@blake-newman blake-newman commented Jun 26, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Reasons

ignore dist files until release
improves contributor experience
ensures dist files can't be accidentally committed in

@blake-newman blake-newman changed the title feat(build): ignore dist files until release chore(git): ignore dist files until release Jun 26, 2017
packages/vue-server-renderer/build.js
packages/vue-server-renderer/server-plugin.js
packages/vue-server-renderer/client-plugin.js
packages/vue-template-compiler/build.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove \n from the end? cat users will hate you 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

ignore dist files until release
improves contributor experience
ensures dist files can't be accidentally committed in
Copy link
Member

@nickmessing nickmessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even a contributor, but anyway, LGTM, I'd like this to be merged.

@yyx990803 yyx990803 merged commit 27a1b03 into vuejs:dev Jun 30, 2017
@blake-newman blake-newman deleted the feature/dist-release-only branch June 30, 2017 15:00
@blake-newman
Copy link
Member Author

@yyx990803 Ill put this across all the core repos with dist folders in coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants