Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weex): support object syntax of class #7930

Merged
merged 2 commits into from
Apr 7, 2018

Conversation

imyzf
Copy link
Contributor

@imyzf imyzf commented Mar 30, 2018

Object syntax class is supported in Weex now:

<div v-bind:class="{ active: isActive }"></div>

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

<div :class="class1"></div>
<div :class="class2"></div>
<div class="box" :class="class3"></div>
<div class="box" :class="class4"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's would be better if you add more inline statement examples in the test case, such as :class="{ active: isActive }".

@Hanks10100 Hanks10100 added the weex label Apr 2, 2018
@yyx990803
Copy link
Member

@Hanks10100 I'll merge once you approve.

@yyx990803 yyx990803 merged commit 6226503 into vuejs:dev Apr 7, 2018
@imyzf imyzf deleted the feature/weex-class branch April 8, 2018 02:26
awamwang added a commit to awamwang/vue that referenced this pull request Jul 8, 2018
* vuejs-dev: (558 commits)
  chore: sponsors
  chore: update sponsors
  chore: update sponsors
  chore: sponsor cleanup
  chore: update sponsors
  chore(package.json): Add sideEffects: false field in package.json (vuejs#8099)
  chore: new sponsor
  chore(typo): no dots at the end of the comments (vuejs#8087)
  chore: new sponsor
  chore: update sponsors
  chore: update sponsors
  chore: use reactive components count in benchmark (vuejs#7996)
  feat(weex): support object syntax of class (vuejs#7930)
  feat(server, webpack-plugin): webpack 4 support (vuejs#7839)
  fix(ssr): render initial and used async css chunks (vuejs#7902)
  fix(ssr): remove trailing hash in webpack module identifier when generating client manifest
  chore: new sponsor
  chore: update sponsor
  build: release 2.5.17-beta.0
  build: build 2.5.17-beta.0
  ...
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants