Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundler-webpack): add api field in sass-loader option type #1588

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat(bundler-webpack): add api field in sass-loader option type #1588

merged 4 commits into from
Jul 25, 2024

Conversation

Mister-Hope
Copy link
Member

No description provided.

@Mister-Hope Mister-Hope requested a review from meteorlxy July 13, 2024 13:18
@coveralls
Copy link

coveralls commented Jul 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10094580206

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.607%
Totals Coverage Status
Change from base Build 10094399086: 0.0%
Covered Lines: 631
Relevant Lines: 1663
💛 - Coveralls

@meteorlxy
Copy link
Member

Closing as sass-loader already prefers sass-embedded over sass since v15.0.0

See: webpack-contrib/sass-loader#1211

@meteorlxy meteorlxy closed this Jul 25, 2024
@meteorlxy meteorlxy reopened this Jul 25, 2024
@meteorlxy
Copy link
Member

meteorlxy commented Jul 25, 2024 •
edited
Loading

Oops I misunderstood the use case. This PR is enabling modern-compiler by default.

We might wait for vite support sass-embedded before merging this. See vitejs/vite#17728

@meteorlxy meteorlxy changed the title perf(bundler-webpack): use modern compiler for sass feat(bundler-webpack): add api field in sass-loader option type Jul 25, 2024
meteorlxy
meteorlxy approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that step by step. Let's add the api option type first.

@meteorlxy meteorlxy merged commit f3251b7 into main Jul 25, 2024
30 checks passed
@meteorlxy meteorlxy deleted the sass branch July 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mister-Hope @coveralls @meteorlxy