Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix bug causing empty product URL paths #64

Merged

Conversation

indiebytes
Copy link
Contributor

Resolves issue #63:

If Divante\VsbridgeIndexerCatalog\Model::getProductUrlSuffix() returns null it will cause an issue in Divante\VsbridgeIndexerCatalog\Model::addUrlPath().

$rewrite = mb_substr($rewrite, 0, -strlen($urlSuffix));

strlen(null) will return 0 which in turn leads to mb_substr() returning an empty string which will be indexed as url_path for the product.

This pull request also contain a minor update that cast $this->productUrlSuffix to string once it's fetched from Magento config.

@afirlejczyk afirlejczyk merged commit 94f6214 into vuestorefront:develop Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants