Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add modern SASS compiler support #255

Merged
merged 14 commits into from
Aug 17, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Aug 15, 2024

This PR includes:

  • update Vite to 5.4.1 via resolutions (Nuxt 3.12.4 using Vite 5.4.0)
  • modern SASS compiler detection and configuration
  • new playground for modern SASS compiler
  • update Vuetify to 3.7.0
  • update pnpm to 9.7.1
  • update VitePress to 1.3.2
  • update @vite-pwa/vitepress to 0.5.0 and include vite-plugin-pwa and workbox-window
  • use Vite virtual convention on constants module, the problem was on vite-plugin-inspect: fix: virtual modules antfu-collective/vite-plugin-inspect#110
  • include DPR in SSR section
  • include modern SASS compiler docs page
  • update Compatibility Matrix

If someone wants to play with the modern-sass-compiler playground (or use the link here #255 (comment)):

  • from root run pnpm install (only once), then run pnpm prepack
  • open a new terminal and change to modern-sass-compiler folder: cd modern-sass-compiler
  • run dev server from modern-sass-compiler folder: pnpm dev
  • you can play with the configuration to enable or disable SASS variables (rn too slow)

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for vuetify-nuxt-module ready!

Name Link
🔨 Latest commit d93d7fa
🔍 Latest deploy log https://app.netlify.com/sites/vuetify-nuxt-module/deploys/66c09a86a393640008a10bb6
😎 Deploy Preview https://deploy-preview-255--vuetify-nuxt-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Aug 15, 2024

commit: d93d7fa

pnpm add https://pkg.pr.new/vuetify-nuxt-module@255

Open in Stackblitz

src/types.ts Show resolved Hide resolved
@userquin userquin marked this pull request as ready for review August 17, 2024 12:21
@userquin userquin merged commit 5675e12 into main Aug 17, 2024
6 checks passed
@userquin userquin deleted the userquin/feat-add-modern-sass-compiler-support branch August 17, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant