-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking-change: change fetch command #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2021
MaineK00n
changed the title
[WIP] feat: change fetch command
feat: change fetch command
Sep 13, 2021
kotakanbe
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
|
||
Global Flags: | ||
--config string config file (default is $HOME/.go-cve-dictionary.yaml) | ||
--dbpath string /path/to/sqlite3 or SQL connection string (default "$PWD/cve.sqlite3") | ||
--dbpath string /path/to/sqlite3 or SQL connection string (default "$HOME/cve.sqlite3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$HOME -> $PWD
kotakanbe
changed the title
feat: change fetch command
breaking-change: change fetch command
Sep 13, 2021
This was referenced Sep 13, 2021
Closed
MaineK00n
pushed a commit
to vulsdoc/vuls
that referenced
this pull request
Jul 26, 2022
> Since we implemented fetching all the years each time, the list command is not so necessary and removed. vulsio/go-cve-dictionary#214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
The options for the fetch command have been changed.
What did you implement:
Removed years, latest, and last2y from fetch command.
By reviewing the fetch procedure, insert speed is stabilized overall, and memory consumption is greatly reduced.
Since we implemented fetching all the years each time, the list command is not so necessary and removed.
In addition, in the part of the JVN fetch that collects Cert, there is an implementation that assumes html as shown below, but in reality there is also txt, etc., so I changed it to parse only for html.
https://github.com/kotakanbe/go-cve-dictionary/blob/69922490c76abccd9bd828f0556b2df49217eae8/fetcher/jvn/jvn.go#L423-L494
Type of change
How Has This Been Tested?
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference