Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fetch/jvn): logging when invalid CVE-ID is found #242

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

Logging when a invalid CVEID is found.

refs. #233

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

$ go-cve-dictionary fetch jvn
...
WARN[12-28|12:04:14] Failed to get CVE-ID. Invalid CVE-ID: CCVE-2021-20208 
INFO[12-28|12:04:14] Inserting fetched CVEs(2021)... 
5544 / 5544 [-------------------------------------------------] 100.00% 2876 p/s
INFO[12-28|12:04:17] Refreshed 5544 CVEs. 
INFO[12-28|12:04:17] Finished fetching JVN.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Dec 28, 2021
@MaineK00n MaineK00n changed the title feat(fetch/jvn): logging when invalid CVE-ID is found chore(fetch/jvn): logging when invalid CVE-ID is found Dec 28, 2021
Copy link
Collaborator

@kotakanbe kotakanbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kotakanbe kotakanbe merged commit 9ea45a2 into master Jan 6, 2022
@kotakanbe kotakanbe deleted the MaineK00n/logging-invalid-cveid branch January 6, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants