Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpescan): match if affected version is NA #283

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Conversation

kotakanbe
Copy link
Collaborator

@kotakanbe kotakanbe commented Oct 19, 2022

What did you implement:

		{
			name: "true: NA should match all version",
			uri:  "cpe:/h:fortinet:fortigate-100d:v6.2.9",
			cpe: models.CpeBase{
				URI: "cpe:/h:fortinet:fortigate-100d:-",
			},
			wantIsExactVerMatch:      true,
			wantIsRoughVerMatch:      false,
			wantIsVendorProductMatch: false,
		},

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

db/db.go Outdated Show resolved Hide resolved
@kotakanbe kotakanbe merged commit 4b59b78 into master Oct 19, 2022
@kotakanbe kotakanbe deleted the fix-cpe-scan branch October 19, 2022 04:39
kotakanbe added a commit to future-architect/vuls that referenced this pull request Oct 19, 2022
kotakanbe added a commit to future-architect/vuls that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants